Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update paths to v2 #144

Merged
merged 5 commits into from
Jun 26, 2019
Merged

Update paths to v2 #144

merged 5 commits into from
Jun 26, 2019

Conversation

cristaloleg
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented Jun 24, 2019

Coverage Status

Coverage remained the same at 90.743% when pulling 2cd0101 on cristaloleg-patch-1 into 0ffb763 on master.

@siennathesane
Copy link
Collaborator

TBH we don't need to do path updates. When installing/downloading, if you call go get github.com/allegro/[email protected], you get it at version 1, and go get github.com/allegro/[email protected].

@siennathesane
Copy link
Collaborator

if you call go get github.com/allegro/[email protected]

Thinking about it, I'm not sure this would work since there is no go.mod.

@gracenoah
Copy link

I suspect that running go get github.com/allegro/[email protected] would add bigcache to your go.mod with the +incompatible suffix to work around the requirement for a /v2 suffix. I'm surprised that no tests failed without the v2 suffix though.
See https://github.com/golang/go/wiki/Modules#can-a-module-consume-a-v2-package-that-has-not-opted-into-modules-what-does-incompatible-mean

@cristaloleg
Copy link
Collaborator Author

@janisz please, have a look

@janisz
Copy link
Collaborator

janisz commented Jun 26, 2019

I'm surprised that no tests failed without the v2 suffix though.

We need to enable modules on travis https://dave.cheney.net/2018/07/16/using-go-modules-with-travis-ci

@cristaloleg
Copy link
Collaborator Author

Huh, wait, why does it work on master? 🤔

@cristaloleg
Copy link
Collaborator Author

Or in this PR also, Go 1.x is 1.12.3 and modules aren't enabled by default

@cristaloleg
Copy link
Collaborator Author

No, wait, why does it work without explicit Go111MODULES ? ;D

@cristaloleg
Copy link
Collaborator Author

Ah, Travis is smart, we're outside of a GOPATH
https://travis-ci.org/allegro/bigcache/jobs/550658078#L437

@cristaloleg cristaloleg merged commit bbf64ae into master Jun 26, 2019
@cristaloleg cristaloleg deleted the cristaloleg-patch-1 branch June 26, 2019 12:37
flisky pushed a commit to flisky/bigcache that referenced this pull request May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants