fix(core): chart pie legend (#33)

allclinics · Nov 8, 2024 · 9a18a80 · 9a18a80
1 parent d6bec4d
commit 9a18a80
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/superset-frontend/plugins/plugin-chart-echarts/src/Pie/transformProps.ts b/superset-frontend/plugins/plugin-chart-echarts/src/Pie/transformProps.ts
@@ -175,6 +175,7 @@ export default function transformProps(
     sliceId,
     showTotal,
     pieChartLegend,
+    pieChartLegendsTopPosition,
   }: EchartsPieFormData = {
     ...DEFAULT_LEGEND_FORM_DATA,
     ...DEFAULT_PIE_FORM_DATA,
@@ -330,11 +331,15 @@ export default function transformProps(
     legend: {
       ...getLegendProps(legendType, legendOrientation, showLegend, theme),
       data: keys,
+      ...(pieChartLegendsTopPosition
+        ? { top: pieChartLegendsTopPosition }
+        : {}),
     },
     graphic: showTotal
       ? {
           type: 'text',
           ...getTotalValuePadding({ chartPadding, donut, width, height }),
+          left: 'center',
           style: {
             text: `${pieChartLegend} ${numberFormatter(totalValue)}`,
             fontSize: 16,

diff --git a/superset-frontend/plugins/plugin-chart-echarts/src/controls.tsx b/superset-frontend/plugins/plugin-chart-echarts/src/controls.tsx
@@ -175,6 +175,19 @@ const pieChartLegend: ControlSetItem = {
   },
 };
 
+const pieChartLegendsTopPosition: ControlSetItem = {
+  name: 'pieChartLegendsTopPosition',
+  config: {
+    type: 'TextControl',
+    label: 'Pie Chart Legends Top Position',
+    renderTrigger: true,
+    default: 0,
+    initialValue: 0,
+    isFloat: true,
+    description: 'Pie Chart Legends Top Position',
+  },
+};
+
 export const showLoaderSection: ControlSetRow[] = [
   [<ControlSubSectionHeader>{t('Loader')}</ControlSubSectionHeader>],
   [showLoader],
@@ -183,6 +196,7 @@ export const showLoaderSection: ControlSetRow[] = [
 export const pieChartLegendrSection: ControlSetRow[] = [
   [<ControlSubSectionHeader>{t('Pie Chart Legend')}</ControlSubSectionHeader>],
   [pieChartLegend],
+  [pieChartLegendsTopPosition],
 ];
 
 export const legendModalSection: ControlSetRow[] = [