-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR for Issue6: projectOwner & projectName is not set in .all-contributorsrc file. #80
Merged
kentcdodds
merged 13 commits into
all-contributors:master
from
M-ZubairAhmed:message-noOwner
May 29, 2018
Merged
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
f9e5597
error message when no project name and project owner is added in the …
f95b879
moved error message away from init prompt
e14510e
1. placed json parse in try catch
4d54771
added check before config file is written
a3159d4
changes as per https://github.com/jfmengels/all-contributors-cli/pull…
e6172a9
uncommented code
a69fd48
tests added
5250432
Added myself to contributors table
ac96910
merge latest to current branch
M-ZubairAhmed 30d2faa
test inside utils were moved to github in master branch
M-ZubairAhmed 862e982
changes to validation check, instead of checking for empty string to …
M-ZubairAhmed dce26d8
typo fixed
M-ZubairAhmed fdcb6dd
unnecisary check.js file removed
M-ZubairAhmed File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
import check from '../check' | ||
|
||
test('Should throw error is no owner or name is present', () => { | ||
expect(() => check('', 'cleave-markdown')).toThrow( | ||
'Error! Project owner is not set in .all-contributorsrc', | ||
) | ||
expect(() => check('M-ZubairAhmed', '')).toThrow( | ||
'Error! Project name is not set in .all-contributorsrc', | ||
) | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
const pify = require('pify') | ||
const request = pify(require('request')) | ||
|
||
function getNextLink(link) { | ||
if (!link) { | ||
return null | ||
} | ||
|
||
const nextLink = link.split(',').find(s => s.includes('rel="next"')) | ||
|
||
if (!nextLink) { | ||
return null | ||
} | ||
|
||
return nextLink.split(';')[0].slice(1, -1) | ||
} | ||
|
||
function getContributorsPage(url) { | ||
return request | ||
.get({ | ||
url, | ||
headers: { | ||
'User-Agent': 'request', | ||
}, | ||
}) | ||
.then(res => { | ||
let body, contributorsIds | ||
try { | ||
body = JSON.parse(res.body) | ||
contributorsIds = body.map(contributor => contributor.login) | ||
} catch (error) { | ||
Error(error) | ||
} | ||
const nextLink = getNextLink(res.headers.link) | ||
if (nextLink) { | ||
return getContributorsPage(nextLink).then(nextContributors => { | ||
return contributorsIds.concat(nextContributors) | ||
}) | ||
} | ||
|
||
return contributorsIds | ||
}) | ||
} | ||
|
||
module.exports = function getContributorsFromGithub(owner, name) { | ||
if (!owner) { | ||
throw new Error('Error! Project owner is not set in .all-contributorsrc') | ||
} | ||
if (!name) { | ||
throw new Error('Error! Project name is not set in .all-contributorsrc ') | ||
} | ||
const url = `https://api.github.com/repos/${owner}/${name}/contributors?per_page=100` | ||
return getContributorsPage(url) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, it's been a little while, but why does this file exist? It doesn't appear to be in use anywhere in the project (other than tests)...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry but this is a node package isn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I should have been more clear. I'm commenting on the file
src/utils/check.js
notpify
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for being late.
It seems that this file was removed in this 152a1fe commit. I retested everything