Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support contributors without github accounts #77

Merged
merged 1 commit into from
Dec 13, 2017

Conversation

chrisinajar
Copy link
Contributor

@chrisinajar chrisinajar commented Dec 13, 2017

What: Fix regression in which if you have any user already added who does not have a github account then the command line fails without any useful error messages.

Why: The spirit of all-contributors is such that all contributors get credit, not just those who are github savvy.

How: Test driven development

Checklist:

  • Documentation -- N/A
  • Tests
  • Ready to be merged
  • Added myself to contributors table

NOTE: This situation only arrises when you have manually added non-github users into your .all-contributorsrc file. This used to work but regressed in recent versions.

@codecov-io
Copy link

Codecov Report

Merging #77 into master will increase coverage by 1.2%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #77     +/-   ##
=========================================
+ Coverage    51.6%   52.81%   +1.2%     
=========================================
  Files          18       18             
  Lines         312      320      +8     
  Branches       39       43      +4     
=========================================
+ Hits          161      169      +8     
+ Misses        136      134      -2     
- Partials       15       17      +2
Impacted Files Coverage Δ
src/contributors/prompt.js 0% <0%> (ø) ⬆️
src/contributors/add.js 100% <100%> (ø) ⬆️
src/generate/format-contribution-type.js 100% <100%> (ø) ⬆️
src/generate/format-contributor.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fa55d5...67111ad. Read the comment docs.

Copy link
Collaborator

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super!

@kentcdodds kentcdodds merged commit 5f9fa20 into all-contributors:master Dec 13, 2017
@kentcdodds
Copy link
Collaborator

Thank you so much :)

@chrisinajar chrisinajar deleted the optional-login branch December 13, 2017 16:47
Berkmann18 pushed a commit that referenced this pull request May 24, 2020
* fix: ensure profile URLs have protocol

* test: fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants