Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] Allow everything except setuptools 50.0.0 #402

Merged
merged 1 commit into from
Dec 2, 2020
Merged

[MRG] Allow everything except setuptools 50.0.0 #402

merged 1 commit into from
Dec 2, 2020

Conversation

aaronreidsmith
Copy link
Member

@aaronreidsmith aaronreidsmith commented Dec 2, 2020 •
edited
Loading

Description

We pinned setuptools to <50.0.0 in #379 due to the issue noted in pypa/setuptools#2356. It seems to only affect v50.0.0, and we never forgot to unpin it. It is now causing issues (See #401). I think this should alleviate that.

Type of change

  • Dependency fix

How Has This Been Tested?

  • Unit tests pass

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@aaronreidsmith aaronreidsmith changed the title [MRG] Allow everything except 50.0.0 [MRG] Allow everything except setuptools 50.0.0 Dec 2, 2020
@aaronreidsmith aaronreidsmith linked an issue Dec 2, 2020 that may be closed by this pull request
pmdarima setuptools update #401
Closed
@aaronreidsmith aaronreidsmith mentioned this pull request Dec 2, 2020
Closed
@tgsmith61591 tgsmith61591 merged commit 6348dae into master Dec 2, 2020
@tgsmith61591 tgsmith61591 deleted the unpin-setuptools branch December 2, 2020 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgsmith61591 tgsmith61591 tgsmith61591 approved these changes

@charlesdrotar charlesdrotar Awaiting requested review from charlesdrotar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pmdarima setuptools update
2 participants
@aaronreidsmith @tgsmith61591