Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AJB-41 - gke-cluster fabric module with auto-provisioning defaults #26

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

baliame
Copy link

@baliame baliame commented Oct 7, 2022

Adds modified version of gke-cluster module where auto_provisioning_defaults for cluster_autoscaling are controllable.

The design choice behind making auto_provisioning_defaults a top-level input block rather than a member of the cluster_autoscaling input object variable is:

  • If added, existing terraform modules which depend on this module which enable cluster_autoscaling will fail as they do not specify the new member of the object.
  • This can be avoided by making the object member optional, but that is an experimental terraform feature and thus has to be explicitly enabled.
    At this point, this is the cleanest and most backwards-compatible way to update this module.

This change is Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant