Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tf-Helm-Helmfile-Kubectl cloud builder #12

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Thomas-Code-Dev
Copy link

@Thomas-Code-Dev Thomas-Code-Dev commented Dec 13, 2021

This change is Reviewable

@Thomas-Code-Dev
Copy link
Author

Authored with @Vagaqt

Copy link
Contributor

@akissds akissds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 7 files at r1.
Reviewable status: 1 of 7 files reviewed, 2 unresolved discussions (waiting on @akissds and @Thomas-Code-Dev)


tf-helm-helmfile-kubectl-cloud-builder/entrypoint.bash, line 5 at r1 (raw file):

active_account=""
function get-active-account() {

Using underscores instead of dashes is more common.


tf-helm-helmfile-kubectl-cloud-builder/README.md, line 19 at r1 (raw file):

### Enable APIs
* `artifactregistry.googleapis.com`
* `cloudbuild.googleapis.com`

You can enable these apis from terraform.

Code quote:

* `artifactregistry.googleapis.com`
* `cloudbuild.googleapis.com`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants