New Resource: alicloud_ess_server_group_attachment. #7696

fuliu-zln · 2024-09-24T04:41:40Z

No description provided.

ChenHanZhang · 2024-09-24T05:42:06Z

alicloud/resource_alicloud_ess_server_group_attachment.go

+		Create: resourceAliyunEssServerGroupAttachmentCreate,
+		Read:   resourceAliyunEssServerGroupAttachmentRead,
+		Update: resourceAliyunEssServerGroupAttachmentUpdate,
+		Delete: resourceAliyunEssServerGroupAttachmentDelete,


Timeouts 加上

ChenHanZhang · 2024-09-24T06:48:41Z

alicloud/resource_alicloud_ess_server_group_attachment.go

+
+	var raw interface{}
+	var err error
+	err = resource.Retry(5*time.Minute, func() *resource.RetryError {


这里使用 schema.TimeoutCreate

ChenHanZhang · 2024-09-24T06:50:30Z

alicloud/resource_alicloud_ess_server_group_attachment_test.go

+		},
+	})
+}
+


补充一个测试并发

补充了冲突重试 + 测试并发

MrWolong · 2024-09-24T09:28:15Z

alicloud/resource_alicloud_ess_server_group_attachment.go

+
+	var raw interface{}
+	var err error
+	err = resource.Retry(d.Timeout(schema.TimeoutCreate), func() *resource.RetryError {


err = resource.Retry(client.GetRetryTimeout(d.Timeout(schema.TimeoutCreate)), func() *resource.RetryError {

MrWolong · 2024-09-24T09:30:08Z

alicloud/resource_alicloud_ess_server_group_attachment.go

+	if activityId == "" {
+		return nil
+	}
+	stateConf := BuildStateConf([]string{}, []string{"Successful"}, d.Timeout(schema.TimeoutCreate), 1*time.Minute, essService.ActivityStateRefreshFunc(activityId, []string{"Failed", "Rejected"}))


schema.TimeoutDelete

MrWolong · 2024-09-24T09:33:28Z

alicloud/resource_alicloud_ess_server_group_attachment_test.go

+	})
+}
+
+func TestAccAliCloudEssServerGroupAttachment_nonForceAttach_mutil(t *testing.T) {


TestAccAliCloudEssServerGroupAttachment_nonForceAttach_mutil单测删了，没有存在的意义，单测冗余，根本不是测试创建多个资源的单测。

这个是chengyi 要求的

MrWolong · 2024-09-24T09:37:37Z

website/docs/r/ess_server_group_attachment.html.markdown

+
+-> **NOTE:** If scaling group's network type is `VPC`, the alb server groups must be in the same `VPC`.
+
+-> **NOTE:** Alb server group attachment is defined uniquely by `scaling_group_id`, `server_group_id`,`type`, `port`.


不要去完全复制粘贴ess_alb_server_group_attachment.html.markdown文档的内容，这个资源是ess_server_group_attachment，不是ess_alb_server_group_attachment

MrWolong · 2024-09-24T09:38:35Z

website/docs/r/ess_server_group_attachment.html.markdown

+
+## Example Usage
+
+<div style="display: block;margin-bottom: 40px;"><div class="oics-button" style="float: right;position: absolute;margin-bottom: 10px;">


MrWolong · 2024-09-24T09:39:49Z

website/docs/r/ess_server_group_attachment.html.markdown

+
+The following attributes are exported:
+
+* `id` - (Required, ForceNew) The ESS alb server group attachment resource ID，in the follwing format: scaling_group_id:


出参id为什么要带(Required, ForceNew)？还有，这个资源是alb server group attachment的吗？改！

MrWolong · 2024-09-24T09:43:32Z

website/docs/r/ess_server_group_attachment.html.markdown

+ESS server groups can be imported using the id, e.g.
+
+```shell
+$ terraform import alicloud_ess_server_group_attachment.example asg-xxx:sgp-xxx:alb:5000 


你看过这个资源的id吗？这个资源的type的入参是大写！

MrWolong · 2024-09-24T09:44:14Z

alicloud/provider.go

@@ -1059,6 +1059,7 @@ func Provider() terraform.ResourceProvider {
 			"alicloud_ess_alarm":                                            resourceAlicloudEssAlarm(),
 			"alicloud_ess_scalinggroup_vserver_groups":                      resourceAlicloudEssScalingGroupVserverGroups(),
 			"alicloud_ess_alb_server_group_attachment":                      resourceAlicloudEssAlbServerGroupAttachment(),
+			"alicloud_ess_server_group_attachment":                          resourceAlicloudEssServerGroupAttachment(),


resourceAliCloudEssServerGroupAttachment

MrWolong · 2024-09-25T06:56:32Z

alicloud/resource_alicloud_ess_server_group_attachment.go

+		Importer: &schema.ResourceImporter{
+			State: schema.ImportStatePassthrough,
+		},
+		Timeouts: &schema.ResourceTimeout{


既然代码中设置了创建和删除的超时时间，文档中也要有体现，文档补齐

MrWolong · 2024-09-25T07:04:54Z

alicloud/resource_alicloud_ess_server_group_attachment_test.go

+					"scaling_group_id": "${alicloud_ess_scaling_group.default.id}",
+				}),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheck(map[string]string{


这几个字段为什么不校验？

MrWolong · 2024-09-25T07:05:23Z

alicloud/resource_alicloud_ess_server_group_attachment_test.go

+					"scaling_group_id": "${alicloud_ess_scaling_group.default.id}",
+				}),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheck(nil),


为什么不校验可查入参？

MrWolong · 2024-09-25T07:08:27Z

alicloud/resource_alicloud_ess_server_group_attachment_test.go

+					"scaling_group_id": "${alicloud_ess_scaling_group.default.id}",
+				}),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheck(map[string]string{


为什么不校验可查入参？

MrWolong · 2024-09-25T07:08:33Z

alicloud/resource_alicloud_ess_server_group_attachment_test.go

+					"scaling_group_id": "${alicloud_ess_scaling_group.default.id}",
+				}),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheck(map[string]string{


为什么不校验可查入参？

MrWolong · 2024-09-25T07:11:57Z

website/docs/r/ess_server_group_attachment.html.markdown

+* `scaling_group_id` - (Required, ForceNew) ID of the scaling group.
+* `server_group_id` - (Required, ForceNew) ID of Server Group.
+* `type` - (Required, ForceNew) The type of server group N. Valid values: ALB, NLB.
+* `port` - (Required, ForceNew) - The port will be used for Alb Server Group backend server.


这个资源是只针对alb的吗？

MrWolong · 2024-09-25T07:12:48Z

alicloud/resource_alicloud_ess_server_group_attachment_test.go

+		}
+
+		if len(scalingGroup.ServerGroups.ServerGroup) > 0 {
+			return WrapError(fmt.Errorf("There are still attached alb server groups."))


testAccCheckEssServerGroupsDestroy这个函数只能用来校验alb的，对吗？

不是 alb 和nlb 通用的将alb描述去掉了

MrWolong

approved

ChenHanZhang

approved

MrWolong

approved

fuliu-zln changed the title ~~New Resource: alicloud_ess_nlb_alb_server_group_attachment.~~ New Resource: alicloud_ess_server_group_attachment. Sep 24, 2024

fuliu-zln force-pushed the feat/newResource branch 3 times, most recently from 4788536 to 0341a0f Compare September 24, 2024 04:50

ChenHanZhang reviewed Sep 24, 2024

View reviewed changes

fuliu-zln force-pushed the feat/newResource branch from 0341a0f to a0b476d Compare September 24, 2024 06:06

ChenHanZhang reviewed Sep 24, 2024

View reviewed changes

fuliu-zln force-pushed the feat/newResource branch 2 times, most recently from ef5fcf0 to 4809649 Compare September 24, 2024 08:36

MrWolong reviewed Sep 24, 2024

View reviewed changes

fuliu-zln force-pushed the feat/newResource branch 2 times, most recently from 12dcc8f to 42aff53 Compare September 25, 2024 06:24

MrWolong reviewed Sep 25, 2024

View reviewed changes

fuliu-zln force-pushed the feat/newResource branch from 42aff53 to 71effcb Compare September 25, 2024 07:10

MrWolong reviewed Sep 25, 2024

View reviewed changes

fuliu-zln force-pushed the feat/newResource branch 3 times, most recently from d17d794 to 42f1dbc Compare September 25, 2024 07:39

New Resource: alicloud_ess_server_group_attachment.

f063f70

fuliu-zln force-pushed the feat/newResource branch from 42f1dbc to f063f70 Compare September 25, 2024 07:52

MrWolong reviewed Sep 25, 2024

View reviewed changes

ChenHanZhang reviewed Sep 26, 2024

View reviewed changes

MrWolong reviewed Sep 26, 2024

View reviewed changes


		-> NOTE: If scaling group's network type is `VPC`, the alb server groups must be in the same `VPC`.

		-> NOTE: Alb server group attachment is defined uniquely by `scaling_group_id`, `server_group_id`,`type`, `port`.


		## Example Usage

		<div style="display: block;margin-bottom: 40px;"><div class="oics-button" style="float: right;position: absolute;margin-bottom: 10px;">


		The following attributes are exported:

		* `id` - (Required, ForceNew) The ESS alb server group attachment resource ID，in the follwing format: scaling_group_id:

New Resource: alicloud_ess_server_group_attachment. #7696

Are you sure you want to change the base?

New Resource: alicloud_ess_server_group_attachment. #7696

Conversation

fuliu-zln commented Sep 24, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fuliu-zln Sep 24, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MrWolong Sep 24, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MrWolong Sep 24, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MrWolong Sep 25, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fuliu-zln Sep 25, 2024 • edited Loading

Choose a reason for hiding this comment

MrWolong left a comment

Choose a reason for hiding this comment

ChenHanZhang left a comment

Choose a reason for hiding this comment

MrWolong left a comment

Choose a reason for hiding this comment

fuliu-zln Sep 24, 2024 •

edited

Loading

MrWolong Sep 24, 2024 •

edited

Loading

MrWolong Sep 24, 2024 •

edited

Loading

MrWolong Sep 25, 2024 •

edited

Loading

fuliu-zln Sep 25, 2024 •

edited

Loading