Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify tag for multi resources #208

Merged
merged 2 commits into from
May 25, 2023
Merged

modify tag for multi resources #208

merged 2 commits into from
May 25, 2023

Conversation

ZRZ2233
Copy link

@ZRZ2233 ZRZ2233 commented May 25, 2023

No description provided.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


zhurenzhu.zrz seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@liketic liketic requested a review from shabicheng May 25, 2023 04:51
@@ -59,6 +59,22 @@ func NewProjectUnTags(project string, tags []string) *ResourceUnTags {
}
}

func NewResourceTags(resourceType string, resourceId string, tags []ResourceTag) *ResourceTags {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comments

@shabicheng
Copy link
Collaborator

/LGTM

@shabicheng shabicheng merged commit 34c0951 into aliyun:master May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants