add CreateMetricStore #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shabicheng
reviewed
Jun 18, 2022
client_metric_store.go
Outdated
|
|
||
| // CreateMetricStore . | ||
| func (c *Client) CreateMetricStore(project, name string, ttl, shard int) error { | ||
| logStore := &LogStore{ |
There was a problem hiding this comment.
让用户自己填入LogStore的配置，然后这边强制把Type设置成Metrics
shabicheng
reviewed
Jun 18, 2022
client_metric_store.go
Outdated
| } | ||
|
|
||
| // UpdateMetricStore . | ||
| func (c *Client) UpdateMetricStore(project, name string, ttl int) error { |
There was a problem hiding this comment.
同样的道理，传入LogStore，然后再强制设置Type为Metrics，最后调用UpdateSubStoreTTL
shabicheng
reviewed
Jun 18, 2022
client_metric_store.go
Outdated
| import "time" | ||
|
|
||
| // CreateMetricStore . | ||
| func (c *Client) CreateMetricStore(project, name string, ttl, shard int) error { |
There was a problem hiding this comment.
需要给ClientInterface加上接口，然后再TokenUpdateClient上也加上对应的实现
https://github.com/aliyun/aliyun-log-go-sdk/blob/master/client_interface.go
|
/LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.