Sync alienv to CVMFS automatically #1459
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As discussed, make sure you back up the old version before deployment of the new one, so that people can use the "safe" version in case of accident. |
|
Is this okay to merge? |
ktf
reviewed
Feb 10, 2025
publish/aliPublishS3
Outdated
| # Create backup with timestamp if files are different | ||
| if not filecmp.cmp(new_alienv, old_alienv, shallow=False): | ||
| timestamp = datetime.now().strftime("%Y%m%d-%H%M%S") | ||
| backup_alienv = f"/cvmfs/alice.cern.ch/bin/alienv.safe-{timestamp}" |
There was a problem hiding this comment.
Maybe we should have a separate folder for the backups (or limit the backups to just a few).
ktf
requested changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to make it as crash resistant as possible, so hopefully it doesn't
interfere with the regular publishing
CC @ktf