Skip to content

Bump alibuild to 1.17.7 on centos&ubuntu repos #1362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 5, 2024

Conversation

singiamtel
Copy link
Collaborator

This version has been available for a while and seems stable. The most
notable change is managing the git repos with --filter=tree:0, which
should mean a notably smaller sw/ folder size

Setting it to draft as centos7 is now EOL, so the action might fail when trying to deploy to those repos

This version has been available for a while and seems stable. The most
notable change is managing the git repos with --filter=tree:0, which
should mean a notably smaller sw/ folder size
@adriansev
Copy link
Collaborator

@singiamtel is alma9 included in this? as in the el9 repository the latest alibuild version is 1.16.1

@adriansev
Copy link
Collaborator

adriansev commented Jul 3, 2024

oh, my bad, i saw in changes that it is... but also note that fedora33 is not among us anymore, it would be best if fedora is to be supported to use fedora 40

@singiamtel
Copy link
Collaborator Author

oh, my bad, i saw in changes that it is... but also note that fedora33 is not among us anymore, it would be best if fedora is to be supported to use fedora 40

Sure, using fedora 40 now

@singiamtel is alma9 included in this? as in the el9 repository the latest alibuild version is 1.16.1

Yeah, I'd prefer to keep the same alibuild version for all repos if possible

@@ -64,14 +64,14 @@ jobs:
set -x
rpmbuild -ba "rpms/o2-prereq-$DISTRO.spec"
git clone -b "$ALIBUILD_TAG" https://github.com/alisw/alibuild
cd alibuild
cd alibuild || exit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check if it is running with set -e?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a cleaner fix indeed, and actionlint doesn't seem to complain. It's now implemented

@singiamtel
Copy link
Collaborator Author

Just tested the centos7 action, and it fails with the same yum repo missing issue. Should we delete it?

@ktf
Copy link
Member

ktf commented Jul 4, 2024

Can we fix it using vault.cern.ch? I am afraid we still have a few things on Centos7.

@singiamtel singiamtel force-pushed the update_alibuild_repos branch from 3305788 to a1de8be Compare July 4, 2024 10:36
@singiamtel singiamtel force-pushed the update_alibuild_repos branch from a1de8be to 99d1ba4 Compare July 4, 2024 10:40
@singiamtel singiamtel force-pushed the update_alibuild_repos branch from 9cc0f1f to 60c2122 Compare July 4, 2024 10:50
@singiamtel
Copy link
Collaborator Author

Can we fix it using vault.cern.ch? I am afraid we still have a few things on Centos7.

Sure, did the workaround

I also had an issue with the Node runner (actions/runner#2906), there is a workaround but we should get it of it as soon as we can drop CentOS 7 support

@singiamtel singiamtel marked this pull request as ready for review July 4, 2024 13:31
@ktf ktf merged commit 0b6d691 into alisw:master Jul 5, 2024
2 checks passed
@ktf
Copy link
Member

ktf commented Jul 5, 2024

We also need the workaround for pip, apparently. See https://github.com/alisw/ali-bot/actions/runs/9805778473. Can you take care of it?

@singiamtel
Copy link
Collaborator Author

singiamtel commented Jul 11, 2024

We also need the workaround for pip, apparently. See alisw/ali-bot/actions/runs/9805778473. Can you take care of it?

@ktf Haven't managed to fix this yet, the python version on their repos is just too old for the new pip. Building python from source would probably work but it means we'd get the compiler toolchain on the image, and the action would take considerably longer to run too

How should we proceed?

Edit: Wrong ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants