-
-
Notifications
You must be signed in to change notification settings - Fork 36
Add net10 support #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add net10 support #138
Conversation
PR Summary
|
|
Looking for review @alirezanet |
alirezanet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks 💐
|
Apparently we need to also update the tests to support .Net 10, although not sure why it is complaining about net9. need to investigate further |
|
Sorry I meant to come back and resolve this, but on reflection perhaps this is the wrong approach long term as this'll keep happening and requires more maintenance than it has to. Ether this should target net standard, which having attempted retargeting I don't think its worth the work, or doing something like this and producing self contained versions at least as an option. |
|
Any plans to finish this? Now that .NET 10 is officially out, it’d be great if Husky.NET supported it. |
Co-authored-by: Weihan Li <[email protected]>
Co-authored-by: Weihan Li <[email protected]>
|
After updating the tool no longer runs and complains that .NET 10 is not installed, even if all projects are only .NET 9, this requires that .NET 10 be installed vs. .NET 10 being supported? |
Hi @ptr727, It should work also with .net 9! please open an issue if you're sure is not working as expected. |
|
I had to install .NET 10 to make it run again on my local machine. Unfortunately I did not capture the error output. |
Description
Unfortunately Husky can't find .net9 inside of a Nix flake/shell when .net 10 is present, so I propose a beta release in preparation of the .net 10 release in November.
Fixes # (issue)
Type of change
Checklist