ec2_snapshot - boto3 migration (ansible-collections#356)

ec2_snapshot - boto3 migration Reviewed-by: Mark Chappell https://github.com/tremble
alinabuzachis · May 5, 2021 · b7087f4 · b7087f4
1 parent c9d7890
commit b7087f4
Show file tree

Hide file tree

Showing 4 changed files with 244 additions and 123 deletions.
diff --git a/changelogs/fragments/356-ec2_snapshot-boto3-migration.yml b/changelogs/fragments/356-ec2_snapshot-boto3-migration.yml
@@ -0,0 +1,4 @@
+minor_changes:
+- ec2_snapshot - migrated to use the boto3 python library (https://github.com/ansible-collections/amazon.aws/pull/356).
+breaking_changes:
+- ec2_snapshot - support for waiting indefinitely has been dropped, new default is 10 minutes (https://github.com/ansible-collections/amazon.aws/pull/356).
diff --git a/plugins/module_utils/waiters.py b/plugins/module_utils/waiters.py
@@ -162,6 +162,19 @@
                 },
             ]
         },
+        "SnapshotCompleted": {
+            "delay": 15,
+            "operation": "DescribeSnapshots",
+            "maxAttempts": 40,
+            "acceptors": [
+                {
+                    "expected": "completed",
+                    "matcher": "pathAll",
+                    "state": "success",
+                    "argument": "Snapshots[].State"
+                }
+            ]
+        },
         "SubnetAvailable": {
             "delay": 15,
             "operation": "DescribeSubnets",
@@ -582,6 +595,12 @@ def route53_model(name):
         core_waiter.NormalizedOperationMethod(
             ec2.describe_security_groups
         )),
+    ('EC2', 'snapshot_completed'): lambda ec2: core_waiter.Waiter(
+        'snapshot_completed',
+        ec2_model('SnapshotCompleted'),
+        core_waiter.NormalizedOperationMethod(
+            ec2.describe_snapshots
+        )),
     ('EC2', 'subnet_available'): lambda ec2: core_waiter.Waiter(
         'subnet_available',
         ec2_model('SubnetAvailable'),