Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling a custom decoding strategy for FirestoreDecoder *HACK* #42

Closed
wants to merge 1 commit into from

Conversation

dannypier
Copy link

This enables an example usage as such

let dateDecoding = FirebaseDecoder.DateDecodingStrategy.custom({ (decoder, value) -> Date in
                        guard let timestamp =  value as? Timestamp else {
                            return Date.distantPast
                        }
                        return timestamp.dateValue()
                    })
let thing = try FirestoreDecoder().decode(Thing.self, from: document.data(), dateDecoding: dateDecoding)

@alickbass
Copy link
Owner

TBH, I think that it is indeed a hack and the proper way would be jus to make Timestamp conform to Codable. Look to this PR #43

@alickbass alickbass closed this May 19, 2018
@dannypier
Copy link
Author

Totally agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants