Update homebrew support #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alichtman
reviewed
Dec 26, 2020
alichtman
reviewed
Dec 26, 2020
alichtman
requested changes
Dec 26, 2020
alichtman
reviewed
Dec 26, 2020
shallow_backup/backup.py
Outdated
Comment on lines
152
to
153
| ret = run_cmd(command) | ||
| if not ret: |
There was a problem hiding this comment.
Suggested change
| ret = run_cmd(command) | |
| if not ret: | |
| if not run_cmd(command): |
|
Good to go after this change. |
Closed
|
Is this still ongoing? And if not, what needs to be done? I am not a python dev, but I would love for this to fix the brew integration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #218.