Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New print_color_bold_path helper methods #173

Merged
merged 6 commits into from
Nov 7, 2018

Conversation

nunomdc
Copy link
Contributor

@nunomdc nunomdc commented Nov 4, 2018

Issue #172

New methods for printing a message in bold with a path description styled without bold.

Copy link
Owner

@alichtman alichtman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's awesome to have these helper methods. Can you replace the hardcoded path formatting currently in the codebase with these helpers?

I'll merge this after the function names are updated and the helper methods are used. There should only be a few instances where I'm printing paths, so this shouldn't take too long.

shallow_backup/printing.py Outdated Show resolved Hide resolved
Copy link
Owner

@alichtman alichtman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fixes. Minor wording and tech debt cleanup and then we're good to go.

shallow_backup/cli.py Outdated Show resolved Hide resolved
shallow_backup/config.py Outdated Show resolved Hide resolved
shallow_backup/git_wrapper.py Outdated Show resolved Hide resolved
shallow_backup/utils.py Outdated Show resolved Hide resolved
shallow_backup/utils.py Outdated Show resolved Hide resolved
shallow_backup/utils.py Outdated Show resolved Hide resolved
@alichtman alichtman merged commit 3fb8108 into alichtman:master Nov 7, 2018
@nunomdc nunomdc deleted the print-path branch November 7, 2018 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants