Expand ~ as user's home directory #161
Conversation
shallow_backup/cli.py
Outdated
| @@ -60,6 +60,7 @@ def cli(add, rm, show, all, dotfiles, configs, packages, fonts, old_path, new_pa | |||
| print_red_bold("Removed config file...") | |||
| elif destroy_backup: | |||
| backup_home_path = get_config()["backup_path"] | |||
| backup_home_path = os.path.abspath(os.path.expanduser(backup_home_path)) | |||
There was a problem hiding this comment.
Let's extract os.path.abspath(os.path.expanduser(VAR)) to a function that lives in utils.py to reduce code repetition.
There was a problem hiding this comment.
Hey, thanks for contributing!
This solution looks like it'll solve the problem, and I can merge this in after some minor refactoring.
Here's a snippet from an article about the DRY principle in software engineering. If you're interested in learning about why it's important, you should read the full article: https://zapier.com/blog/dont-repeat-yourself/
In software engineering, DRY is the principle of reducing repetition in the code,
referring back to a single source—or "snippet"—of reusable code whenever you need it.
Instead of repeating the same nested function calls 3/4 places, we should add a single function that accomplishes the same functionality, and just call that function instead.
After this is fixed, I'll pull this branch down for testing and merge it.
|
I can see where you're coming from, although if we're going to move this into a separate function then we could also explore the possibility to expand system environment variables on path inputs |
I'm confused what you mean by this. Can you provide an example where this would be useful? |
Co-Authored-By: nunomdc <[email protected]>
For instance, accepting the following inputs:
|
|
Yes, that's an awesome idea. Let's do it. Created #164 so I can merge this. |
Should fix issue #155.