Add --add and --rm path to Action Menu #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alichtman
commented
Oct 28, 2018
shallow_backup/cli.py
Outdated
| @@ -29,14 +29,15 @@ | |||
| @click.option('-reinstall_packages', is_flag=True, default=False, help="Reinstall packages.") | |||
| @click.option('-reinstall_all', is_flag=True, default=False, help="Full reinstallation.") | |||
| @click.option('--remote', default=None, help="Set remote URL for the git repo.") | |||
| @click.option('--rm', default=None, type=str, help="Remove path from config.") | |||
| @click.option('-show', is_flag=True, default=False, help="Show config file.") | |||
| @click.option('--rm', default=None, type=str, help="Remove path from backup.") | |||
There was a problem hiding this comment.
Add note about how to remove configs and plists (and check that it's actually implemented too)
shallow_backup/config.py
Outdated
| sys.exit(1) | ||
| elif section == "other": | ||
| print(Fore.RED + Style.BRIGHT + "ERR: Option not currently supported." + Style.RESET_ALL) | ||
| # TODO: Finish proofing this for which abs/non-abs paths get printed and stored. |
There was a problem hiding this comment.
Finish proofing this method for which abs/non-abs paths get printed and stored.
This shouldn't happen.
|
Issue: Broken --add [ARG ARG] The issue here is that nargs is either set to 2 or 3, and won't let the last arg be optional. Need to figure out how to make it optional.
One potential solution is to make |
|
New gameplan:
|
alichtman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#156 #140
Related to #129