Skip to content

Commit

Permalink
(github-actions) fix: only lint in node 22.x
Browse files Browse the repository at this point in the history
  • Loading branch information
alichry committed Feb 16, 2025
1 parent 53a6291 commit aa4eeb3
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 6 deletions.
22 changes: 18 additions & 4 deletions .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [14.x, 16.x, 18.x]
node-version: [14.x, 16.x, 18.x, 20.x, 22.x]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/
steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v2
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- name: Install root dependencies
Expand Down Expand Up @@ -62,10 +62,24 @@ jobs:
node import.mjs
echo "Testing CJS require"
node require.cjs
- name: Lint packages
run: |
set -e
if [ "${{ matrix.node-version }}" = "22.x" ]; then
lerna run lint
fi
website:
name: "Build website"
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Use Node.js 22
uses: actions/setup-node@v4
with:
node-version: 22.x
- name: Install website dependencies
working-directory: ./website
run: npm install
- name: Build website
working-directory: ./website
run: npm run build

run: npm run build
2 changes: 1 addition & 1 deletion packages/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"transpile:cjs": "tsc --project tsconfig.build.cjs.json --outDir ./dist/cjs",
"posttranspile:cjs": "echo '{\"type\": \"commonjs\"}' > ./dist/cjs/package.json",
"transpile": "npm run transpile:esm && npm run transpile:cjs",
"build": "npm run lint && npm run transpile",
"build": "npm run transpile",
"test": "c8 mocha --loader=ts-node/esm 'test/**/*.{ts,js}'",
"prepublishOnly": "npm run build && npm run test"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/sst/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"transpile:cjs": "tsc --project tsconfig.build.cjs.json --outDir ./dist/cjs",
"posttranspile:cjs": "echo '{\"type\": \"commonjs\"}' > ./dist/cjs/package.json",
"transpile": "npm run transpile:esm && npm run transpile:cjs",
"build": "npm run lint && npm run transpile",
"build": "npm run transpile",
"test": "c8 mocha --loader=ts-node/esm 'test/**/*.{ts,js}'",
"prepublishOnly": "npm run build && npm run test"
},
Expand Down

0 comments on commit aa4eeb3

Please sign in to comment.