-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge master branch from upstream plus openexr support #5
Conversation
Openexr-2 already includes imath, so we cannot mix them.
@fabiencastan This PR fixes AliceVision build on Windows: alicevision/AliceVision#1238. The build on that PR still fails, but this is because of alicevision/AliceVision#1233 is not merged yet. |
@fabiencastan @simogasp Could you merge this PR so that I could finish fixing things on the main AliceVision project side? |
OpenEXR-3 has been merged in vcpkg today, so I think we can just use the latest version of vcpkg. |
@fabiencastan That would work great! Thanks. |
done |
467509e
to
8e8a3d7
Compare
Thank you! But which version do you mean can now be used used?
* https://github.com/microsoft/vcpkg
* https://github.com/alicevision/vcpkg
…On Mon, Sep 26, 2022 at 7:41 PM Fabien Castan ***@***.***> wrote:
OpenEXR-3 has been merged in vcpkg today, so I think we can just use the
latest version of vcpkg.
I can upgrade the alicevision_master branch. Would that be ok for you?
—
Reply to this email directly, view it on GitHub
<#5 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABTWKFKCSOROW4BQCF5GU4TWAHG3PANCNFSM6AAAAAAQU52GD4>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
This PR merges upstream master branch plus openexr3 support from microsoft#26862.