Sync 3D camera with image selection #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [nodes] SfM: make more generic method to get SfM results and return solved intrinsics in addition to views and poses * [reconstruction] store and expose solved intrinsics by viewpoints
keep reference to active prepareDenseScene to be able to compose paths to undistorted images
* new class that wraps an input image (Viewpoint) in the context of a Reconstruction * exposes properties to access image and camera data
Inspector3D is not an overlay anymore to simplify 3D manipulations, by having view center at the center of the 3D view.
* Inspector * changed "SETTINGS" to "DISPLAY" * new "CAMERA" section: activate camera synchronization + control image overlay * ImageOverlay: new component to display (undistorted) image on top of the 3D view * ViewpointCamera: new component that sets up a Camera based on a Viewpoint internal parameter * Viewer3D: additional ViewpointCamera to perform synchronization with image selection * Viewer3DSettings: new properties related to camera synchronization mode
Only prompt right-click contextual menu when it was not used to zoom in the 3D view.
Using an additional scale Transform changes Cuboid's size relatively to the Camera locator, which was unwanted.
don't trigger Camera selection if mouse has moved to rotate camera
* add MouseArea at root of media * use flow to display media info and avoid text clipping
Helper method to set a node as the active one of its type.
To be consistent with the Graph Editor behavior, double clicking on a node sets it as the active node of its type. This, for example, enables to switch from one SfM to another from the media list.
* flatten the button * color its icon when checked
correctly apply image transformation to principal point correction in uv coordinates.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new feature that enables to synchronize 3D camera pose with the image selection.
After the computation of the StructureFromMotion step, a dedicated 3D camera can be controlled by choosing an image from the input Images list, allowing to view the reconstruction from this image's POV (pose and field of view).
If the PrepareDenseScene step is computed, the undistorted image can also be displayed as an overlay on the 3D view.
Features list
Implementation remarks