Improve Graph Editor UX #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgeertsen
force-pushed
the
dev/nodesAndTaskManager
branch
from
e9b4d58
to
326f45d
Compare
fabiencastan
requested changes
Sep 10, 2019
There was a problem hiding this comment.
- Keep node name in the top bar of the node ( and should not be outside to avoid complex overlays with other nodes). We can put the additional icon flags on the right. We should use a color for the top-bar of the node to avoid the confusing "disabled" aspect.
- "Submit" (in the node right click menu) should be disabled if a previous node is computing or submitted
- Nodes connections: put the connection line in bold when ready to connect
- Revisit grey/white color code for param connections:
- Connected input param in grey is good
- Output param connection of an input argument should not have the same color than the output-only ones
- Do not allow to start a new connection on an already connected input param
- Use the label (instead of the name) for the duplicates (to be consistent with the node title)
fabiencastan
approved these changes
Sep 14, 2019
fabiencastan
requested changes
Sep 14, 2019
This was referenced Sep 18, 2019
|
@lgeertsen Good work! How about adding an option to hide (collapse) the inputs/outputs to simplify the node graph and expand them if needed? |
Create a seperate class to handle the logic of computing nodes + An UI overview with all submitted nodes
Add possibilty to, while computing nodes: add more nodes to the task manager, edit, duplicate and remove nodes without breaking the tasks that are submitted
…if one is the exact input
fabiencastan
reviewed
Sep 4, 2020
…desAndTaskManager Conflicts: meshroom/core/graph.py meshroom/ui/qml/main.qml
fabiencastan
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redesigned Nodes
Inputs and outputs are now ordered vertically. And the inputs and outputs are now separated left and right which makes it easier to visualize the graph
When nodes are computing or submitted, all the nodes in that branch are locked.
Added a lock icon and on overlay over the attributes.
While locked none of the attributes can be edited and no new inputs can be attached nor deleted.
While locked outputs can still be connected.
If a nodes in a branch have the same values as a node in another branch than an icon will be displayed to indicate that this node is a duplicate.
When you hover over the icon a tooltip will be displayed with the name of the original node.
Nodes that are being computed on a renderfarm will have a cloud icon.
TaskManager
Nodes submitted to a render farm are now also managed by the task manager