Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Graph Editor UX #612

Merged
merged 115 commits into from
Dec 3, 2020
Merged

Improve Graph Editor UX #612

merged 115 commits into from
Dec 3, 2020

Commits on Nov 29, 2019

  1. Create TaskManager with a task overview

    Create a seperate class to handle the logic of computing nodes
    + An UI overview with all submitted nodes
    lgeertsen authored and yann-lty committed Nov 29, 2019
    Configuration menu
    Copy the full SHA
    51d6c18 View commit details
    Browse the repository at this point in the history
  2. Don't lock graph and node editor while computing nodes

    Add possibilty to, while computing nodes:
    add more nodes to the task manager,
    edit, duplicate and remove nodes without breaking the tasks that are submitted
    lgeertsen authored and yann-lty committed Nov 29, 2019
    Configuration menu
    Copy the full SHA
    c00db25 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    01974c2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fe3c55e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f4e5e84 View commit details
    Browse the repository at this point in the history
  6. Lock Nodes and Edges during computing

    lgeertsen authored and yann-lty committed Nov 29, 2019
    Configuration menu
    Copy the full SHA
    6d83985 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    34a9056 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    3c32aae View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    5aea330 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    5fd0045 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    31c46f1 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    72c0606 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    0d01a22 View commit details
    Browse the repository at this point in the history
  14. [UI] Change node width

    lgeertsen authored and yann-lty committed Nov 29, 2019
    Configuration menu
    Copy the full SHA
    7e6436c View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    3ff5ba8 View commit details
    Browse the repository at this point in the history
  16. [UI] change node attributePin ui

    lgeertsen authored and yann-lty committed Nov 29, 2019
    Configuration menu
    Copy the full SHA
    502e912 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    9f5775c View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    f083309 View commit details
    Browse the repository at this point in the history
  19. Delete print

    lgeertsen authored and yann-lty committed Nov 29, 2019
    Configuration menu
    Copy the full SHA
    c88881e View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    70509f5 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    c128080 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    bbe40e0 View commit details
    Browse the repository at this point in the history
  23. [ui] GraphEditor: fix QML errors

    - fix anchors/layout/padding conflicts
    - fix references to non-existing variables
    - fix anchors to a position and not to an object
    fabiencastan authored and yann-lty committed Nov 29, 2019
    Configuration menu
    Copy the full SHA
    72e0e64 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    65c472f View commit details
    Browse the repository at this point in the history
  25. [ui] main: fix: graph can be null

    fabiencastan authored and yann-lty committed Nov 29, 2019
    Configuration menu
    Copy the full SHA
    48b11b5 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    5f28a8f View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    f1267d7 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2020

  1. [core] add "Attribute.hasOutputConnections" property

    Give access to whether an attribute has output connections.
    yann-lty committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    fcb2b23 View commit details
    Browse the repository at this point in the history
  2. [ui] Node: improve attribute display

    * display filled pin when attribute has output connections
    * start removing duplicated code
    * tweak sizing/spacing 
    * fix anchor errors
    yann-lty committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    e2ef652 View commit details
    Browse the repository at this point in the history
  3. [ui] Node: improve node UI

    * unify colors and spacing
    * simplify status icon display
    * remove duplicated code
    yann-lty committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    6186670 View commit details
    Browse the repository at this point in the history
  4. [ui] Edge: fix control points distance

    Avoid getting increasingly distorted curves with edge width.
    yann-lty committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    efb8e1e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ac149e1 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    79d35ac View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    16c9e0c View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    991aca9 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    b883bd1 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2020

  1. Configuration menu
    Copy the full SHA
    bab908d View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2020

  1. Configuration menu
    Copy the full SHA
    68162e1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8a9499a View commit details
    Browse the repository at this point in the history
  3. [core/ui] add a locked property on nodes

    Add locked property on core nodes and update UI in the same commit because both parts are very dependent for this change.
    julien-hdev committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    ff7f8b3 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2020

  1. Configuration menu
    Copy the full SHA
    041cb8b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8a5f493 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fd51237 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    de83294 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    02b9e34 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2020

  1. [ui] Node: fix slowness due to QML function calls with a lot of nodes

    Instead of calling the duplicateList function for each node, at each modification, it is called only when we press the button.
    julien-hdev committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    d838e78 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0af2f32 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2020

  1. Configuration menu
    Copy the full SHA
    a3e0d53 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2083d83 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d6f9ee1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    723e007 View commit details
    Browse the repository at this point in the history
  5. [core] Node: stopComputation method

    - Node: stopComputation method.
    - Task Manager: avoid stopping the entire task manager when a node is stopped.
    julien-hdev committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    b71832e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f41565f View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2020

  1. Configuration menu
    Copy the full SHA
    11e68e7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ba1994d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    57bb9a4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    79e1c69 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ae7daf0 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ed83532 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2020

  1. 2 Configuration menu
    Copy the full SHA
    044ef17 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2020

  1. [core] TaskManager: forceStatus parameter

    Implement back the forceStatus parameter which is helpful in command-line to force computing nodes already submitted or running externally.
    julien-hdev committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    2099bad View commit details
    Browse the repository at this point in the history
  2. [core] TaskManager: improve log message in the compute method

    It gives a better way to identify the error in QML.
    julien-hdev committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    be49e37 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    32a7005 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a00c82c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    44821a1 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2020

  1. Configuration menu
    Copy the full SHA
    3e82a21 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3e5e4cf View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3033e79 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9316b82 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6eeea3b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    201ab0b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    fb477d4 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    eaad870 View commit details
    Browse the repository at this point in the history
  9. [core] Graph: remove warning logs from dfsToProcess method

    Those warnings happen already in the Task Manager and should be handled only by the Task Manager.
    julien-hdev committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    e64c66e View commit details
    Browse the repository at this point in the history
  10. [ui] Main: fix action triggered by "Quit" button

    Make sure to pass through the onClosing signal handler instead of just force quit the application.
    julien-hdev committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    91bd464 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    8281f8c View commit details
    Browse the repository at this point in the history
  12. [ui] Node: duplicates button improvement but still perf issues

    As described in the comment, for an unknown reason, the icon seems to make the UI slow in some cases but not always.
    julien-hdev committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    06b8213 View commit details
    Browse the repository at this point in the history
  13. [core] Graph: avoid double update while adding/removing an edge

    Graph.markNodesDirty() is called in three different places:
    - Attribute.requestGraphUpdate()
    - Graph.addEdge()
    - Graph.removeEdge()
    
    However, addEdge() and removeEdge() are especially decorated to request a graph update so, with the old markNodesDirty() implementation, the update was done twice in a row.
    julien-hdev committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    74fa302 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2020

  1. Configuration menu
    Copy the full SHA
    b5e126c View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2020

  1. Configuration menu
    Copy the full SHA
    5d63d02 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    11bf682 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f502625 View commit details
    Browse the repository at this point in the history
  4. [core] TaskManager: restart/block thread when stop computing

    - If global stop: block restarting thread.
    - If local stop: restart thread with the remaining nodes to compute.
    
    This implementation permits to avoid app freezing when a local stop occurs.
    julien-hdev committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    58790e3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e0389ad View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2020

  1. [ui] Commands: handle undo stack while computing and submitting

    Computing: lock the undo stack at the current index to avoid going back too far and potentially alter computing process.
    Submitting: clear the undo stack.
    julien-hdev committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    5f444e6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    eb52459 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5722ef5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    95c7a9b View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2020

  1. Configuration menu
    Copy the full SHA
    78f7feb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3f3a6c0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3fc09dd View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a19ef35 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    bdf96e2 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2020

  1. Configuration menu
    Copy the full SHA
    49e33fb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f8bd40a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    208749d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b567d8f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e4a95e8 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    44d019b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8499431 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    deaf1e3 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    37c758c View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    0693af5 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    0345672 View commit details
    Browse the repository at this point in the history
  12. [core] Graph.findNode: if multiple candidates, do not raise an error …

    …if one is the exact input
    fabiencastan committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    c8978cd View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    69e9495 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    dba781a View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2020

  1. Configuration menu
    Copy the full SHA
    635f362 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    827e98a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bd4c816 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9403873 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e91dab1 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2020

  1. Merge branch 'develop' of github.com:alicevision/meshroom into dev/no…

    …desAndTaskManager
    
    Conflicts:
    	meshroom/core/graph.py
    	meshroom/ui/qml/main.qml
    fabiencastan committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    1102ce8 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2020

  1. Configuration menu
    Copy the full SHA
    a0206a8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bfdf2ea View commit details
    Browse the repository at this point in the history