Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FloatImageViewer: support multi-resolution #39

Merged
merged 9 commits into from
Sep 6, 2023
Merged

Conversation

mugulmd
Copy link
Contributor

@mugulmd mugulmd commented Aug 8, 2023

Description

Modifications to the FloatImageViewer and SequenceCache to adapt the images resolution to a given target size.

This PR also includes several improvements regarding request management and prefetching.

Features

  • use target size to determine downscale
  • make sure there is always at most one prefetching thread
  • add flag to abort prefetching

Also we rely on alicevision/AliceVision#1504 to allow retrieving images from cache while images are loading from disk in the prefetching thread, which avoids blocking the UI.

@mugulmd mugulmd marked this pull request as ready for review August 10, 2023 10:21
@cbentejac cbentejac merged commit a8dce80 into develop Sep 6, 2023
@cbentejac cbentejac deleted the mug/multiResImg branch September 6, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants