Compute or Submit selected nodes #2459
Open
+59
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just-Kiel
force-pushed
the
dev/submitOrComputeSubgraph
branch
from
b9e8fd1
to
32b53e8
Compare
cbentejac
requested changes
Jul 16, 2024
Comment on lines
+458
to
+476
| MenuItem { | ||
| text: "Compute Selected Node(s)" | ||
| visible: uigraph.selectedNodes.count > 0 | ||
| height: visible ? implicitHeight : 0 | ||
|
|
||
| enabled: { | ||
| var canCompute = false | ||
| for (var i = 0; i < uigraph.selectedNodes.count; ++i) { | ||
| if (uigraph.graph.canCompute(uigraph.selectedNodes.at(i)) && uigraph.graph.canSubmitOrCompute(uigraph.selectedNodes.at(i))%2 == 1){ | ||
| canCompute = true | ||
| } | ||
| } | ||
| return canCompute | ||
| } | ||
|
|
||
| onTriggered: { | ||
| computeRequest(uigraph.selectedNodes) | ||
| } | ||
| } |
There was a problem hiding this comment.
There is no need to add a second menu to compute/submit the selected nodes. Everything that's done with these menus should instead be done with the regular "Compute" and "Submit" to avoid confusions for the user.
Comment on lines
+484
to
+500
| MenuItem { | ||
| text: "Submit Selected Node(s)" | ||
| visible: uigraph.selectedNodes.count > 0 | ||
| height: visible ? implicitHeight : 0 | ||
|
|
||
| enabled: { | ||
| var canSubmit = false | ||
| for (var i = 0; i < uigraph.selectedNodes.count; ++i) { | ||
| if (uigraph.graph.canCompute(uigraph.selectedNodes.at(i)) && uigraph.graph.canSubmitOrCompute(uigraph.selectedNodes.at(i)) > 1){ | ||
| canSubmit = true | ||
| } | ||
| } | ||
| return canSubmit | ||
| } | ||
|
|
||
| onTriggered: { | ||
| submitRequest(uigraph.selectedNodes) |
| enabled: { | ||
| var canCompute = false | ||
| for (var i = 0; i < uigraph.selectedNodes.count; ++i) { | ||
| if (uigraph.graph.canCompute(uigraph.selectedNodes.at(i)) && uigraph.graph.canSubmitOrCompute(uigraph.selectedNodes.at(i))%2 == 1){ |
There was a problem hiding this comment.
Suggested change
| if (uigraph.graph.canCompute(uigraph.selectedNodes.at(i)) && uigraph.graph.canSubmitOrCompute(uigraph.selectedNodes.at(i))%2 == 1){ | |
| if (uigraph.graph.canCompute(uigraph.selectedNodes.at(i)) && uigraph.graph.canSubmitOrCompute(uigraph.selectedNodes.at(i)) % 2 == 1) { |
| enabled: { | ||
| var canSubmit = false | ||
| for (var i = 0; i < uigraph.selectedNodes.count; ++i) { | ||
| if (uigraph.graph.canCompute(uigraph.selectedNodes.at(i)) && uigraph.graph.canSubmitOrCompute(uigraph.selectedNodes.at(i)) > 1){ |
There was a problem hiding this comment.
Suggested change
| if (uigraph.graph.canCompute(uigraph.selectedNodes.at(i)) && uigraph.graph.canSubmitOrCompute(uigraph.selectedNodes.at(i)) > 1){ | |
| if (uigraph.graph.canCompute(uigraph.selectedNodes.at(i)) && uigraph.graph.canSubmitOrCompute(uigraph.selectedNodes.at(i)) > 1) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this feature, it is possible to submit or compute the current selected nodes even if they are not next to each other. The dependencies are defined separately to then create the tasks.