Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Display an icon on nodes that have viewable outputs #2047

Merged
merged 3 commits into from
Jun 12, 2023

Conversation

cbentejac
Copy link
Contributor

Description

This PR adds an icon on nodes with outputs that can be visualised with the 2D Viewer (following #1776).

When a node has been computed, if it has at least one viewable output, an icon appears next to its name with a tooltip indicating that it can be loaded by double-clicking it.

@cbentejac cbentejac added the UI label Jun 9, 2023
@cbentejac cbentejac added this to the Meshroom 2023.2.0 milestone Jun 9, 2023
@cbentejac cbentejac self-assigned this Jun 9, 2023
Add a property that is set to True if at least one of the node's output
attributes has the "image" semantic and can thus be loaded in the 2D
Viewer.
…loaded

If the node has been computed (i.e. its status is `SUCCESS`) and has at
least one output that can be loaded in the 2D viewer, then display an icon
with a tooltip that indicates that double-clicking the node allows to load
it and its outputs in the 2D Viewer.
@cbentejac cbentejac marked this pull request as draft June 9, 2023 15:33
@cbentejac cbentejac marked this pull request as ready for review June 12, 2023 11:57
@mugulmd mugulmd merged commit dc0cb0c into develop Jun 12, 2023
@mugulmd mugulmd deleted the dev/imageSemanticIcon branch June 12, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants