Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nodes] StereoPhotometry: Fix some labels and descriptions #2034

Merged
merged 2 commits into from
Jun 12, 2023

Conversation

cbentejac
Copy link
Contributor

@cbentejac cbentejac commented Jun 5, 2023

Description

Related AliceVision pull request: alicevision/AliceVision#1452

This PR fixes the label and description for the output folder of the SphereDetection node, as well as some parameters' description in the LightingCalibration node.

The `SphereDetection` node does not output any information related to
lighting, it only outputs a folder that will contain the information of
the spheres detected in the input images.
In particular, the `inputPath` parameter currently does not support folders
for now, so this mention should be stripped from it.
@fabiencastan fabiencastan merged commit c9dd362 into develop Jun 12, 2023
@fabiencastan fabiencastan deleted the dev/psImprovements branch June 12, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants