[nodes] KeyframeSelection: Add support for SfMData files as inputs and outputs #1967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mugulmd
reviewed
Apr 11, 2023
mugulmd
reviewed
Apr 11, 2023
mugulmd
reviewed
Apr 11, 2023
mugulmd
reviewed
Apr 11, 2023
There was a problem hiding this comment.
you could add a dynamic node size to the node using the size member variable: this would enable the chunk mechanism for the nodes after this one in a pipeline
This commit updates the name of the input parameter (from "mediaPaths" to "inputPaths") as it now also supports SfMData files, and adds two SfMData files as output parameters: one that contains the selected keyframes, and one that contains the frames that were not selected as keyframes.
Indicate that this file is not written as an output if the input is a video or a list of videos.
cbentejac
force-pushed
the
dev/sfmDataKeyframeSelection
branch
from
09b7a14
to
903134f
Compare
mugulmd
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is related to alicevision/AliceVision#1406, and adds the support of
SfMDatafiles as inputs and outputs.In particular:
outputSfMDataKeyframesandoutputSfMDataFrameswhich areSfMDatafiles which respectively contain all the selected keyframes and all the input frames that were not selected as keyframes;inputPathsparameter to indicate theSfMDatafiles are supported;sensorDbPathparameter (trivial).Features list
SfMDatafiles;SfMDatafiles.