Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[panorama] option to build contact sheet #1945

Merged
merged 2 commits into from
Apr 27, 2023
Merged

Conversation

servantftechnicolor
Copy link
Contributor

Add a parameter in panoramaInit to enable or not the contact sheet generation.

The contact sheet is then generated if an XML file is present to initialize the camera poses.

The contact sheet is some preview of the panorama using the inputs.

Copy link
Contributor

@cbentejac cbentejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I rebased the PR on develop and added an extra commit to disable the buildContactSheet attribute when there is no XML file.

Additionally fix the case of the "buildContactSheet" label and improve
the description.
@cbentejac cbentejac merged commit 1dc490c into develop Apr 27, 2023
@cbentejac cbentejac deleted the dev/contactSheet branch April 27, 2023 15:53
@cbentejac cbentejac added this to the Meshroom 2023.2.0 milestone Apr 27, 2023
@fabiencastan fabiencastan added the feature new feature (proposed as PR or issue planned by dev) label Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new feature (proposed as PR or issue planned by dev)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants