[ui] ImageGallery: Allow image drop if the active group is not computing #1941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbentejac
force-pushed
the
fix/blockedDragDrop
branch
from
7871dbd
to
ca4996d
Compare
mugulmd
reviewed
Mar 21, 2023
cbentejac
force-pushed
the
fix/blockedDragDrop
branch
from
ca4996d
to
126e800
Compare
mugulmd
reviewed
Mar 21, 2023
mugulmd
reviewed
Mar 21, 2023
cbentejac
force-pushed
the
fix/blockedDragDrop
branch
from
126e800
to
11a8700
Compare
The Image Gallery should only switch to read-only if the currently active group is being computed. The behaviour prior to this commit was to lock it as soon as any node in the entire graph was being computed, even if it did not involve the active CameraInit node.
cbentejac
force-pushed
the
fix/blockedDragDrop
branch
from
11a8700
to
7488ee2
Compare
mugulmd
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the behaviour of the Image Gallery, which used to switch to read-only as soon as a node in the entire graph was being computed. This meant that no image could be dropped in the gallery if there was any ongoing computation, even if the nodes that were computed did not include or involve the active
CameraInitnode.The computation status of the active
CameraInitnode is now taken into account when determining whether the Image Gallery should be read-only or not.Features list
CameraInitnode is locked because of computations.