[ui] Image Gallery: Fix the display of the intrinsics table with temporary CameraInit nodes #1934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When setting a temporary CameraInit node, the intrinsics of the actual CameraInit node are used, meaning that the temporary CameraInit has all the intrinsics information we need to fill the intrinsics table. However, when a temporary CameraInit node is set, the parsing of the intrinsics and the model update are not performed. If the active CameraInit group does not change, this is not directly visible as the table keeps on displaying the intrinsics from the actual CameraInit node. If the active group changes, we attempt to fill the table with the intrinsics of the temporary CameraInit node, which is being re-set for the active group. The intrinsics are thus not available, leading to an empty table, and the parsing is never retriggered once the temporary CameraInit has been fully set. Instead of re-parsing the intrinsics when the CameraInitIndex is updated, the parsing is triggered when the intrinsics are updated, since this ensures they will be available and its covers all the cases we could be facing.
As the temporary CameraInit nodes are not really part of the graph, their attributes cannot be edited. By default, the intrinsics can be edited for any CameraInit node from the intrinsics table. For temporary CameraInit nodes, we want the intrinsics to be displayed in read-only mode to ensure that the user cannot attempt to edit them, which would cause errors. Upon its creation, the temporary CameraInit node is locked (as if it were computed), and the intrinsics table's component are updated to be displayed as read-only if the CameraInit node is locked.
fabiencastan
approved these changes
Mar 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a temporary
CameraInitnode was created, its intrinsics (set to be identical to the currently activeCameraInitnode) were not parsed and the intrinsics table was not updated with them. This issue was not visible if there was a singleCameraInitnode in the graph, as its intrinsics were still displayed, making it seem like the intrinsics were those of the temporaryCameraInitnode.However, when there were several
CameraInitgroups, switching from one group's temporaryCameraInitnode to another's would generate a QML error and cause the intrinsics table to be empty.This PR addresses this issue by correctly parsing the intrinsics when temporary
CameraInitnodes are created, thus correctly filling the intrinsics table at all times.It also handles an issue that was directly caused by this fix: since temporary
CameraInitnodes are not part of the graph, they cannot be edited, and attempting to edit a temporaryCameraInit's intrinsics from the table would cause errors.To prevent this from happening, temporary
CameraInitnodes are set aslockedupon their creation, and the intrinsics table goes in read-only mode when the intrinsics of such a node are displayed. Since nodes are automaticallylockedwhile they are involved in computations, this also prevents any edit to the intrinsics ofCameraInitnodes in that context.Finally, three minor changes were made:
Features list
locked.