[ui] Prompt a warning dialog when attempting to submit an unsaved project #1927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A project needs to be saved in order to be submitted to the renderfarm. Prior to this commit, attempting to submit an unsaved project would not prompt any dialog in the UI despite the exception that was thrown on the Python side. A warning dialog is now opened to let the user know that the project cannot be submitted until it is saved.
fabiencastan
approved these changes
Mar 10, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A project needs to be saved in order to be submitted to the renderfarm. However, attempting to submit an unsaved project does not prompt any dialog in the UI, despite the exception that is thrown on the Python side.
This PR improves that behaviour by opening a warning dialog that lets the user know their project needs to be saved in order to be submitted.