Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] GraphEditor: create new pipelines with the node menu #1833

Merged
merged 6 commits into from
Dec 5, 2022

Commits on Nov 29, 2022

  1. [ui] GraphEditor: Add a "Pipelines" category in the node menu

    Artificially add a "Pipelines" category in the node menu. The category
    contains the list of available pipeline templates. Selecting a pipeline
    instead of a regular node type "creates" the pipeline in the GraphEditor
    (using the "import project" functionality). The imported pipeline is
    by default placed under the current graph.
    
    This commit does not include enabling the search for pipelines from the
    "Pipelines" category in the search bar.
    cbentejac committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    04ab813 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2022

  1. [ui] GraphEditor: Import pipeline on the mouse's position with the no…

    …de menu
    
    If a pipeline is imported with the node menu instead of the "Import
    Project" action from the File menu, the top-left "corner" of the graph
    should be placed on the mouse's position.
    The position of pipelines imported with the "Import Project" menu
    remains unchanged: they are automatically placed below the lowest
    node in the current graph.
    cbentejac committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    c2570ca View commit details
    Browse the repository at this point in the history
  2. [ui] Add a "pipelineTemplateNames" property

    This property simplifies and optimizes the addition of templates in
    the node menu and their import into the graph, as it prevents us from
    looping over the entire "pipelineTemplateFiles" dictionary to retrieve
    the information we need.
    cbentejac committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    2e5f471 View commit details
    Browse the repository at this point in the history
  3. [ui] GraphEditor: Add the pipelines in the node menu's search bar

    Pipelines can be searched in the list of available node types / pipelines
    like regular node types.
    cbentejac committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    aedf0ef View commit details
    Browse the repository at this point in the history
  4. [ui] GraphEditor: clear node selection before adding new nodes from t…

    …he menu
    
    This commit is a bugfix.
    When adding new nodes with the node menu, the selection was never
    explicitly cleared and nodes were added to the selection rather than
    being exclusively selected.
    
    This behaviour used to be hidden when the node menu could only appear
    with a right click, as the click would automatically empty the
    selection. However, with the node menu being now openable with the TAB
    key, there might not be a click to empty the selection. If new nodes
    are added by opening the menu with the TAB key and using the arrow keys
    to select the node to create, an infinite number of them can be created
    and added to the selection.
    cbentejac committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    9d88ad9 View commit details
    Browse the repository at this point in the history
  5. [ui] GraphEditor: select pipelines imported through the node menu

    Add all the nodes from a pipeline imported through the node menu to the
    node selection.
    This involves changing the return value of ImportProjectCommand from a
    boolean to a list of imported nodes.
    cbentejac committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    6a36da6 View commit details
    Browse the repository at this point in the history