[ui] Restrain the "copy/paste nodes" shortcuts to the GraphEditor #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a Ctrl+C or Ctrl+V shortcut is performed outside the GraphEditor, the performed action should not be a copy or a paste of the nodes, but the own copy/paste of the current element (e.g. if a Ctrl+C is made on on the NodeEditor, then the copied element should be the one selected in the NodeEditor, not the currently selected node).
fabiencastan
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue introduced with #1758 which overrides any Ctrl+C / Ctrl+V shortcut with a "Copy node(s)" / "Paste node(s)", no matter which part of Meshroom has the focus or which element is currently selected.
If a Ctrl+C or Ctrl+V shortcut is performed outside the GraphEditor, the performed action should not be a copy or a paste of the nodes, but the own copy/paste of the current element. For example, if the currently selected element is a text field in the NodeEditor, then using Ctrl+C shoud trigger that text field's own copy function and copy its content to the clipboard; "Copy node(s)" and "Paste node(s)" should only be called when Ctrl+C and Ctrl+V are performed within the GraphEditor.