Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Update intrinsics table when switching between groups #1755

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

cbentejac
Copy link
Contributor

Description

This PR fixes a UI bug that would cause the displayed intrinsics table to always be the first CameraInit node's, no matter which group the user wanted to display. The intrinsics table was loaded once on the first CameraInit node and never reloaded after that, so if there was more than a single CameraInit node in the graph, the corresponding tables could not be displayed.

The intrinsics table is now correctly reloaded when the group index is changed.

@fabiencastan fabiencastan added this to the Meshroom 2022.1.0 milestone Aug 23, 2022
@fabiencastan fabiencastan merged commit 2005324 into develop Aug 23, 2022
@fabiencastan fabiencastan deleted the fix/uiIntrinsicsTable branch August 23, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants