Add abstract InitNode #1750
Merged
Add abstract InitNode #1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiencastan
reviewed
Aug 4, 2022
cbentejac
force-pushed
the
dev/abstractCamInit
branch
from
78f4dfb
to
2754f97
Compare
fabiencastan
reviewed
Aug 5, 2022
InitNode is an abstract class which is meant to be inherited by all the initialization nodes (such as CameraInit), included those that might be created by the user. InitNode contains methods that can be reimplemented by the children classes if necessary. This abstract class allows to keep on using scripts such as meshroom_batch without having to modify them specifically or being limited to using a CameraInit node.
cbentejac
force-pushed
the
dev/abstractCamInit
branch
from
2754f97
to
659c8a0
Compare
fabiencastan
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the abstract class "InitNode" which is meant to be inherited by all the initialization nodes (such as CameraInit), included those that might be created by the user. InitNode contains methods that can be reimplemented by the children classes if necessary.
This abstract class allows to keep on using scripts (such as meshroom_batch) without being limited to the use a specific initialization node (like it used to be with CameraInit in the case of meshroom_batch, for example), needing to have the knowledge of the used initialization node and/or having to modify the scripts as a workaround.