[ui] Fix offset between the mouse's position and the tip of the edge when connecting two nodes #1732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving the mouse rapidly when starting to connect two nodes' attributes could lead to an unwanted offset between the tip of the edge and the mouse's position; it forced the user to move the mouse further than the attribute pin they wanted to connect to in order to actually be able to connect to it.
The attributes' pins are now vertically aligned with their matching labels.
Harmonize the highlighting of the attributes' pins when they are hovered and clicked on, may they already be connected to other nodes or not.
fabiencastan
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the offset between the tip of the connecting edge and the position of the mouse that could appear when the user quickly dragged the mouse away from the attribute pin. The offset could at times be extremely large, causing issues when trying to connect the edge somewhere (the user needed to position the tip of the edge on the attribute pin with the mouse being positioned sometimes really far away from said attribute pin).
Features list