Use project files to define pipelines #1727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the value of the string parameters in the nodes' description as the unevaluated variable instead of the evaluated variable. The evaluation will be made later, when the nodes with such parameters will be computed.
- Support loading external pipelines as templates with project files - Add template files for some standard pipelines - Remove the hard-coded generation of new pipelines - Update multiviewPipeline test: the multiviewPipeline test relied on the hard-coded generation of pipelines.
cbentejac
force-pushed
the
dev/externalPipelines
branch
from
5f418fe
to
c29574b
Compare
The "New Pipeline" menu is automatically filled with the list of the project files that were found dynamically. Pipelines can thus be initialized with templates without restarting Meshroom app.
cbentejac
force-pushed
the
dev/externalPipelines
branch
from
c29574b
to
578c1f0
Compare
When a project file is opened as such, its filepath is stored and all its features are retrieved as a consequence. Templates were hard-coded instead of opened as files, so there never was any need to load their features. Now that .mg files can be opened both as projects and pipelines, we need to retrieve the features in both cases, whether the filepath is stored (file opened as project) or not (file opened as template). This can be useful to retrieve the layout contained in the .mg file for the pipeline, for example.
fabiencastan
approved these changes
Jul 25, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initialize pipelines in Meshroom using .mg project files that are found dynamically based on an environment variable. This replaces the hard-coded generation of pipelines that used to take place when the user was using the "New Pipeline" option. Standard templates are added and always found by default, independently from the content of the environment variable set by the user.
Features list