Add nl means denoising open cv in image processing node #1719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiencastan
requested changes
Jul 12, 2022
tanstella
force-pushed
the
AddNLMeansDenoisingOpenCVInImageProcessingNode
branch
from
2e87824
to
aaa8504
Compare
|
Done |
cbentejac
force-pushed
the
AddNLMeansDenoisingOpenCVInImageProcessingNode
branch
from
aaa8504
to
85a3f2a
Compare
fabiencastan
reviewed
Dec 5, 2022
…default value Change HColor default value from 5 to 10 as advised in the documentation of OpenCV's non-local means denoising. Also update the description of the H and HColor parameters so that they are easier to understand. The name of the parameters is also updated to match with parameters from other groups.
cbentejac
force-pushed
the
AddNLMeansDenoisingOpenCVInImageProcessingNode
branch
from
098f4dc
to
826b57e
Compare
fabiencastan
approved these changes
Dec 13, 2022
fabiencastan
deleted the
AddNLMeansDenoisingOpenCVInImageProcessingNode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added parameters in ImageProcessing node for denoising by OpenCV (NLMeans denoising)
Based on alicevision/AliceVision#1181