-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ui] Add filters to image gallery #1500
Merged
fabiencastan
merged 39 commits into
alicevision:develop
from
N0Ls:dev/ImageGalleryFilter
Sep 2, 2021
Merged
[ui] Add filters to image gallery #1500
fabiencastan
merged 39 commits into
alicevision:develop
from
N0Ls:dev/ImageGalleryFilter
Sep 2, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add the possibility to filter the images inside the image gallery. * Clickables buttons * All images filter * Reconstructed images filter * Non reconstructed images filter
Add the number of instrinsics detected on the bottom bar of the image gallery.
Remove the files used when the display was made by a list view based on the attribute editor.
* Change color to match software's palette * Use trick to remove unwanted digits when not being edited
* Only displayed when button checked * View updated when adding or deleting intrinsics
N0Ls
force-pushed
the
dev/ImageGalleryFilter
branch
3 times, most recently
from
August 23, 2021 14:17
a3877b8
to
56d91bd
Compare
Adding new properties and updating the call to previous ones. Properties are now : * label : getLabel * fullLabel : getFullLabel * fullLabelToNode : getFullLabelToNode * fullLabelToGraph : getFullLabelToGraph Same for the name.
* Width of columns is now provided by a column width provider * Text inputs now cover all the column width * Text inputs now are right aligned for easier reading/comparing
Specify boundsMovement property to avoid overshooting with the flicks
Add clipping to columns so the text doesn't overflow everywhere Co-authored-by: Fabien Castan <[email protected]>
[doc] readme: add citation
) * documentation: how to use Meshroom without building AliceVision * documentation: explain how to start and debug with PyCharm * add comments as examples in start.sh * fix wrong bash and if not in right dir (related with alicevision@692ecfa#commitcomment-53971206)
…room into N0Ls-dev/ImageGalleryFilter
Keep a valid index when changing the type of view
fabiencastan
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New filter buttons at the bottom of the image gallery.
Allows to view filtered views of images.
Allows to view and edit intrinsics.
[python]
New python properties to get the name/label of an attribute with different level of precision/hierarchy.
Features list
Remarks
For now and because of version incompatibility, the headers for the intrinsics display are disabled and replaced with tooltips.