Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Add filters to image gallery #1500

Merged
merged 39 commits into from
Sep 2, 2021

Conversation

N0Ls
Copy link
Contributor

@N0Ls N0Ls commented Aug 10, 2021

Description

New filter buttons at the bottom of the image gallery.
Allows to view filtered views of images.
Allows to view and edit intrinsics.

imagegallery

[python]
New python properties to get the name/label of an attribute with different level of precision/hierarchy.

Features list

  • Filtered view for reconstructed cameras
  • Filtered view for non-reconstructed cameras
  • Placeholder when the view doesn't contain any filtered images
  • Intrinsics display as a tableview
  • Rename and expose new properties (label / name) inside the python

Remarks

For now and because of version incompatibility, the headers for the intrinsics display are disabled and replaced with tooltips.

@fabiencastan
Copy link
Member

[WARNING] file:///C:/dev/meshroom/meshroom/ui/qml/ImageGallery/ImageGallery.qml:72: TypeError: Cannot read property 'count' of undefined
[WARNING] file:///C:/dev/meshroom/meshroom/ui/qml/ImageGallery/ImageGallery.qml:363:17: QML TableModel: appendRow(): expected a property named "Id" in row at index -1, but couldn't find one
[WARNING] file:///C:/dev/meshroom/meshroom/ui/qml/ImageGallery/IntrinsicDisplayDelegate.qml:119: TypeError: Cannot read property 'desc' of null

N0Ls added 21 commits August 17, 2021 15:58
Add the possibility to filter the images inside the image gallery.
* Clickables buttons 
* All images filter
* Reconstructed images filter
* Non reconstructed images filter
Add the number of instrinsics detected on the bottom bar of the image gallery.
Remove the files used when the display was made by a list view based on the attribute editor.
* Change color to match software's palette
* Use trick to remove unwanted digits when not being edited
* Only displayed when button checked
* View updated when adding or deleting intrinsics
@N0Ls N0Ls force-pushed the dev/ImageGalleryFilter branch 3 times, most recently from a3877b8 to 56d91bd Compare August 23, 2021 14:17
Adding new properties and updating the call to previous ones.
Properties are now :
* label : getLabel
* fullLabel : getFullLabel
* fullLabelToNode : getFullLabelToNode
* fullLabelToGraph : getFullLabelToGraph

Same for the name.
* Width of columns is now provided by a column width provider
* Text inputs now cover all the column width
* Text inputs now are right aligned for easier reading/comparing
@fabiencastan fabiencastan added this to the Meshroom 2021.2.0 milestone Sep 2, 2021
@fabiencastan fabiencastan merged commit cde2c7b into alicevision:develop Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants