Allow replacing edges #1355
Merged
Allow replacing edges #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @ChemicalXandco for the contribution. That's a good feature. In term of implementation, I would like to avoid adding complexity to the low level commands. From the ui, just create a group of modifications: remove the edge and add a new one. What do you think? |
fabiencastan
approved these changes
Apr 9, 2021
|
The PR looks good to me. I will merge it now, but it would be good to display in red the edge that will be removed, like here between MeshFiltering and Texturing: |
I agree, so I will make a PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes using the graph editor more efficient because if I have node A connected to node C but then I want to connect node B to node C instead then I would have to first delete the edge from node A to node C before it was possible to drag the edge from node B to node C. With these changes it is possible to do this without having to explicitly delete the previous edge.