Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[panorama] PanoramaCompositing: new out-of-core algorithm #947

Merged
merged 82 commits into from
Feb 12, 2021

Conversation

ghost
Copy link

@ghost ghost commented Dec 7, 2020

These updates enable the creation of very large panoramas.

--> optimized algorithms to work on tiles
--> creation of disk cache to remove the RAM barrier


for (int i = 0; i < height; i++) {
//#pragma omp parallel for
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To remove or to uncomment?

if (AminusB.size() != B.size()) {
return false;
}
omp_set_num_threads(std::min(omp_get_thread_limit(), std::max(0, maxThreads)));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
omp_set_num_threads(std::min(omp_get_thread_limit(), std::max(0, maxThreads)));
if(maxThreads > 0)
omp_set_num_threads(std::min(omp_get_thread_limit(), maxThreads));

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It means that 0 would equals to auto ?

Allows to downscale input warps on-the-fly and compute seams in lower resolution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants