Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tetrahedral intersection #848

Merged
merged 26 commits into from
Jan 21, 2021
Merged

Improve tetrahedral intersection #848

merged 26 commits into from
Jan 21, 2021

Conversation

dsmtE
Copy link
Contributor

@dsmtE dsmtE commented Jul 30, 2020 •
edited
Loading

Description

Improvement of intersection methods by using a more precise/advanced representation of geometry to handle unusual cases (intersection with an edge or vertex), avoid unnecessary computations and deal with holes and spikes issues.

Example of spikes issues

Before / After
before1after1

Before / After
before2after2

Features list

  • Create struct and functions for geometry intersection
  • Fix the order during the insertion of camera's points (579fa9c)

the camera points were deleted after being added and were therefore not considered to be part of the tetrahedralization points

  • Replace old intersection implementation
  • Add a progress Bar
  • Improve debugging
    • Cleaner log messages
    • Export a mesh representation of the tetrahedralization vote
    • Add a history structure for debugging intersected geometries
    • Export votes values as csv
  • Add small unit test

@dsmtE dsmtE force-pushed the dev/improveTetrahedralIntersection branch 5 times, most recently from 639f2f2 to d4b8063 Compare August 4, 2020 08:52
@dsmtE dsmtE force-pushed the dev/improveTetrahedralIntersection branch 2 times, most recently from 37d444f to fe4dc74 Compare August 7, 2020 08:26
@fabiencastan fabiencastan marked this pull request as ready for review January 20, 2021 19:02
@dsmtE @fabiencastan
[fuseCut] add struct for advanced geometry intersection
88443ca
@dsmtE @fabiencastan
[fuseCut] delaunayGraphCut: Add a function to get neighbouring cells …
8e44731 
…by the edge
@dsmtE @fabiencastan
[fuseCut] DelaunayGraphCut: fix the order during the insertion of cam…
d43ed97 
…era's points
@dsmtE @fabiencastan
[fuseCut] DelaunayGraphCut: Add progress Bar
0e0049c
@dsmtE @fabiencastan
[fuseCut] delaunayGraphCut: add geometry intersections functions
91d5f92 
Add new functions to handle intersections with new geometry struct.
Allows us to deal with the specific cases of edges and vertices
@dsmtE @fabiencastan
[fuseCut] DelaunayGraphCut: new implementation using geometry (CRITIC)
4fe8bbb
@dsmtE @fabiencastan
[fuseCut] DelaunayGraphCut: remove old implementation
3e36c89
@dsmtE @fabiencastan
[fuseCut] clean
5f70f8f
@dsmtE @fabiencastan
[FuseCut] DelaunayGraphCut: Add geometries history
4fc5383 
- add a history structure for debugging purposes
@dsmtE @fabiencastan
[FuseCut] DelaunayGraphCut: update mesh export for debugging
08123ba 
- small clean and new optional variables for mesh export
- add new functions to export meshes for debugging
@dsmtE @fabiencastan
[fuseCut] DelaunayGraphCut: add unit test
3c24426
@dsmtE @fabiencastan
[fuseCut] DelaunayGraphCut: Use an adaptive epsilon factor for the in…
e3f77e3 
…tersection of geometries
@dsmtE @fabiencastan
[fuseCut] DelaunayGraphCut: Remove unused EDirection struct
0c5fb60
@dsmtE @fabiencastan
[fuseCut] DelaunayGraphCut: export csv data for debugging purposes
30f8e92
@dsmtE @fabiencastan
[fuseCut] DelaunayGraphCut: renaming and more detailed log message fo…
1992601 
…r fillGraph and forceTedges
@dsmtE @fabiencastan
[fuseCut] DelaunayGraphCut: generalize getNeighboringCells for geomet…
ca58646 
…ries
@dsmtE @fabiencastan
[fuseCut] DelaunayGraphCut: add equality operators for few struct
6b7218f
@dsmtE @fabiencastan
[fuseCut] DelaunayGraphCut: fix new implementation
64db42f
@dsmtE @fabiencastan
[mvsData] getLineTriangleIntersectBarycCoords: use double instead of …
e26fa79 
…float

reduce the number of failure cases
@dsmtE @fabiencastan
[fuseCut] DelaunayGraphCut: handle ambigious case in rayIntersectTria…
432964c 
…ngle

- Add ambiguityEpsilon to handle cases where the direction test is ambiguous
- Use double instead of float
- renaming epsilon => marginEpsilon
@dsmtE @fabiencastan
[fuseCut] DelaunayGraphCut : define an adapted value for marginEpsilon
24117a9
@dsmtE @fabiencastan
[FuseCut] DelaunayGraphCut: cleaner debug messages
87903cb
@fabiencastan fabiencastan force-pushed the dev/improveTetrahedralIntersection branch from 9203b30 to 5b2930a Compare January 20, 2021 19:11
@fabiencastan fabiencastan changed the title Dev/improve tetrahedral intersection Improve tetrahedral intersection Jan 20, 2021
@fabiencastan fabiencastan force-pushed the dev/improveTetrahedralIntersection branch from 598b29b to 5e545ae Compare January 20, 2021 22:13
@fabiencastan fabiencastan added this to the 2.4.0 milestone Jan 21, 2021
@fabiencastan fabiencastan merged commit 105b8a5 into develop Jan 21, 2021
@fabiencastan fabiencastan deleted the dev/improveTetrahedralIntersection branch January 21, 2021 15:06
@fabiencastan fabiencastan mentioned this pull request Feb 9, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregoire-dl gregoire-dl gregoire-dl approved these changes

@fabiencastan fabiencastan fabiencastan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@dsmtE @fabiencastan @remmel @gregoire-dl