Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update required CMake version #811

Merged
merged 1 commit into from
Jun 12, 2020

Conversation

AmirYalamov
Copy link
Contributor

@AmirYalamov AmirYalamov commented Jun 12, 2020

Description

While building on my machine (Linux - Ubuntu 18.04) I ran into the prompt CMake 3.11 or higher is required. when running cmake for the first time. I have changed the required CMake version in the isntallation instructions to reflect the new tool version requirement.

Features list

  • updated CMake version

Implementation remarks

Please let me know if I need to update anything else in the file to reflect my new change.

@flosincapite please review.

Copy link

@flosincapite flosincapite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Are you able to add one of the AliceVision folks as a reviewer?

@simogasp simogasp self-assigned this Jun 12, 2020
@simogasp simogasp added the doc label Jun 12, 2020
@simogasp simogasp added this to the 2020.1.0 milestone Jun 12, 2020
Copy link
Member

@simogasp simogasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AmirYalamov
Copy link
Contributor Author

Looks good to me! Are you able to add one of the AliceVision folks as a reviewer?

I am not, I don't have the option to on the side bar in the Reviewers space

@simogasp simogasp merged commit 4590ae8 into alicevision:develop Jun 12, 2020
@simogasp
Copy link
Member

thanks for the first contribution! ;-)

@AmirYalamov AmirYalamov deleted the update_dependencies branch June 12, 2020 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants