Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[appveyor] build alicevision snapshot binaries (win) #753

Merged
merged 17 commits into from
Mar 30, 2020

Conversation

natowi
Copy link
Member

@natowi natowi commented Mar 10, 2020

setup appveyor to release windows binaries from the develop branch

For every commit, a snapshot build for windows can be downloaded from the appveyor build artifacts tab.

Details: https://www.appveyor.com/docs/packaging-artifacts/

Note: (to be added to the wiki)
Do not use snapshots if you need a stable version.
Snapshot builds are for developers and testers and should be considered unstable.

With snapshots, users can test and report back on a bugfix/feature without waiting for the official release or needing to build alicevision on their own.

"setup appveyor to release windows binaries from the develop branch"
#392 (comment)

Save auto builds to https://ci.appveyor.com/project/AliceVision/alicevision/build/artifacts for download to test new features.
https://www.appveyor.com/docs/packaging-artifacts/
@natowi natowi changed the title alicevision appveyor snapshot binaries [WIP] alicevision appveyor snapshot binaries Mar 10, 2020
@natowi natowi added the review label Mar 10, 2020
@natowi natowi added the ready label Mar 13, 2020
@natowi natowi changed the title [WIP] alicevision appveyor snapshot binaries alicevision appveyor snapshot binaries Mar 13, 2020
@natowi natowi changed the title alicevision appveyor snapshot binaries [appveyor] build alicevision snapshot binaries (win) Mar 14, 2020
@natowi
Copy link
Member Author

natowi commented Mar 16, 2020

@simogasp any comments? I´d like to merge this as it reduces issues from people trying to build av on their own.

@simogasp
Copy link
Member

I cannot try it as i don't have a windows machine? Did you? Do you need an appveyor login to download it?
In any case it should be made clear that they are developer versions and there may be bugs &C.
Also, maybe it would be better to add the hash of the commit to the name, so it is always possible to know which version it is.

@natowi
Copy link
Member Author

natowi commented Mar 16, 2020

I cannot try it as i don't have a windows machine? Did you? Do you need an appveyor login to download it?

Yes, I have tried the build and it works. No, the artifact can be downloaded without login.

In any case it should be made clear that they are developer versions and there may be bugs &C.

Yes, that is why I would not push this to the releases. Releases should be stable. I would not advertise this too much, as this is primarily for people who want to try out some new features or WIP PR without going through the hassle of setting up the build environment on their computer. I think we could mention this on a wiki page.

Also, maybe it would be better to add the hash of the commit to the name, so it is always possible to know which version it is.

That is a good idea. Something like APPVEYOR_REPO_BRANCH-prAPPVEYOR_PULL_REQUEST_NUMBER ?

https://www.appveyor.com/docs/environment-variables/

after_build:
  - set BUILD_ARCHIVE=%APPVEYOR_BUILD_FOLDER%\build\alicevisionWin64snapshot-%APPVEYOR_REPO_BRANCH%-pr%APPVEYOR_PULL_REQUEST_NUMBER%.zip
  - 7z a %BUILD_ARCHIVE% %APPVEYOR_BUILD_FOLDER%\build\Windows-AMD64\Release\*

artifacts:
  - path: 'build\*.zip'

@simogasp
Copy link
Member

APPVEYOR_PULL_REQUEST_HEAD_COMMIT seems to me more appropriate, once you have the hash you always know which version it is.
I don't know how often these artefacts are produced, for every commit?

@natowi
Copy link
Member Author

natowi commented Mar 16, 2020

I don't know how often these artefacts are produced, for every commit?

Artifacts are produced for every commit, as appveyor is used as as part of the CI/check. It is build anyway, this PR just provides a way to download the build.

This is the new filename: alicevisionWin64snapshot-f22c9504f635d3845a60670fc577a727ea47d64d.zip

@natowi
Copy link
Member Author

natowi commented Mar 16, 2020

ToDo

  • add *.md files from %APPVEYOR_BUILD_FOLDER% (COPYING, LICENSE,...) to zip

@natowi
Copy link
Member Author

natowi commented Mar 27, 2020

COPY command is not supported.

Testing to add the files directly to the zip archive

@fabiencastan
Copy link
Member

@natowi It is ready to be integrated?
(In order to keep a clean history, I plan to use squash instead of merge for this PR.)

@natowi natowi merged commit cb07231 into develop Mar 30, 2020
@natowi natowi deleted the appveyor-snapshot-binaries branch March 30, 2020 19:19
@simogasp simogasp added this to the 2020.1.0 milestone Mar 30, 2020
@natowi
Copy link
Member Author

natowi commented Mar 30, 2020

Any ideas why the squash merged PR failed cb07231 ?
I made sure the build succeeded before merging: https://ci.appveyor.com/project/AliceVision/alicevision/builds/31822915

@simogasp
Copy link
Member

maybe a timeout?

@natowi
Copy link
Member Author

natowi commented Mar 30, 2020

Yes, could be. In this case this will be resolved with the next merge or by manually restarting the build via the appveyor project page.

@fabiencastan
Copy link
Member

fabiencastan commented Mar 30, 2020

Yes, I just restarted the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants