New panorama pipeline for fisheye images #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
- new param maxTotalPoints - samplesFolder is required only if the method is not linear
- PanoramaWarping: export extra info (panorama size and warp tile offset) in metadata (instead of an additional json file) - PanoramaCompositing: now requires an input SfM to be able to load warped images
The UID generation has been updated, so if there is no unique ID in the image metadata, the full path of the image will be used. This breaks the ways we generate identical UID for GT evaluation. So with this PR, the GT comparaison uses the number extracted from the filename to create the UID.
…cs are incoherents
- Sampling/Calibration/Merge supports the case of NO multi-bracketing - Rename the output param of LdrToHdrMerge - Add an index offset to control the bracket index to use as the reference for the target exposure - The notion of target views is now only used in LdrToHdrMerge (and no more in sampling/calibration)
simogasp
approved these changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for HDRI creation from fisheye images.
Features list
Implementation remarks