[cmake] using modern cmake for boost #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simogasp
force-pushed
the
cmake/modernBoost
branch
from
f6e221a
to
5eb0bb6
Compare
manually adding it may result in double flag
simogasp
commented
Jan 15, 2020
src/CMakeLists.txt
Outdated
| @@ -252,7 +252,7 @@ endif() | |||
| # ============================================================================== | |||
| option(BOOST_NO_CXX11 "if Boost is compiled without C++11 support (as it is often the case in OS packages) this must be enabled to avoid symbol conflicts (SCOPED_ENUM)." OFF) | |||
| set(ALICEVISION_BOOST_COMPONENTS atomic container date_time filesystem graph log log_setup program_options regex serialization system thread timer) | |||
| find_package(Boost 1.60.0 QUIET CONFIG COMPONENTS ${ALICEVISION_BOOST_COMPONENTS}) | |||
| find_package(Boost 1.60.0 QUIET COMPONENTS ${ALICEVISION_BOOST_COMPONENTS} unit_test_framework) | |||
There was a problem hiding this comment.
if(ALICEVISION_BUILD_TESTS)
list(APPEND ALICEVISION_BOOST_COMPONENTS unit_test_framework)
endif()
There was a problem hiding this comment.
But unit_test_framework should not be exported in the Config as it's not needed when AliceVision is used as an external library.
There was a problem hiding this comment.
true.
But if you use it as 3rd party normally you don't build the tests that are set to OFF by default.
Nevertheless, we need some conditions here, because for the same reason you don't need to find the test framework if you are not building the tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boost::*find_dependencyfor boost when AV is used as 3rd party