Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noise reduction in HDR merging #1469

Merged
merged 6 commits into from
Jul 5, 2023
Merged

Conversation

demoulinv
Copy link
Contributor

@demoulinv demoulinv commented Jun 16, 2023

Description

Update the HDR merging algorithm to reduce the resulting noise when the majority of the original LDR images are under exposed and very dark.
Optionally compute and output 3 light mask (darklights, highlights, no midlights) for the purpose of the LDR stack of views analysis.

linked to alicevision/Meshroom#2072

Features list

  • Update the interface of the selectTargetView function by returning the index of the selected reference view.
  • Add 2 new parameters (min and max significant values) in the main LDR_to_HDR_merge executable.
  • Update hdr process method with the new algorithm.
  • Output 3 light masks (darklights, highlights, no midlights).

Implementation remarks

The main idea of the algorithm update is to determine for each channel of each pixel an optimal set of views to be merged. Assuming that the views are sorted from the shortest to the longest exposure (from the darkest to the brightest views) and a reference view has been selected, starting from the index of the reference view the index to start is decremented while the channel value is higher than the minimum significant value. Starting from the computed first index incremented by 1, the last index is incremented while the channel value is lower than the maximum significant value.

@demoulinv demoulinv force-pushed the dev/hdrMergingNoiseReduction branch from c32b5c8 to a95dd3c Compare June 28, 2023 14:08
@demoulinv demoulinv marked this pull request as ready for review June 28, 2023 14:09
@mugulmd mugulmd added this to the 3.2.0 milestone Jul 5, 2023
@mugulmd mugulmd merged commit 3e9f63a into develop Jul 5, 2023
@mugulmd mugulmd deleted the dev/hdrMergingNoiseReduction branch July 5, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants