Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panorama was using too much memory for no reason #1462

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Panorama was using too much memory for no reason #1462

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/software/pipeline/main_panoramaCompositing.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ size_t getCompositingOptimalScale(int width, int height)
* Ideally, should be gaussianFilterSize = 1 + 2 * gaussianFilterRadius with:
* const size_t gaussianFilterRadius = 2;
*/
const int gaussianFilterSize = 1;
const int gaussianFilterSize = 5;

//Avoid negative values on scale
if (minsize < gaussianFilterSize)
Expand Down Expand Up @@ -163,6 +163,10 @@ bool processImage(const PanoramaMap& panoramaMap, const sfmData::SfMData& sfmDat
panoramaBoundingBox = referenceBoundingBox.divide(panoramaMap.getScale())
.dilate(panoramaMap.getBorderSize())
.multiply(panoramaMap.getScale());

panoramaBoundingBox.clampTop();
panoramaBoundingBox.clampBottom(panoramaMap.getHeight());

compositer = std::unique_ptr<Compositer>(
new LaplacianCompositer(panoramaBoundingBox.width, panoramaBoundingBox.height, panoramaMap.getScale()));
}
Expand Down